[Groonga-commit] droonga/droonga-engine at 2eb99e3 [master] Recover error from an invalid "date" field

Back to archive index

YUKI Hiroshi null+****@clear*****
Thu Jan 15 12:32:35 JST 2015


YUKI Hiroshi	2015-01-15 12:32:35 +0900 (Thu, 15 Jan 2015)

  New Revision: 2eb99e3f08c0499a7c226ff33d09bb912782c898
  https://github.com/droonga/droonga-engine/commit/2eb99e3f08c0499a7c226ff33d09bb912782c898

  Message:
    Recover error from an invalid "date" field

  Modified files:
    lib/droonga/engine.rb

  Modified: lib/droonga/engine.rb (+9 -1)
===================================================================
--- lib/droonga/engine.rb    2015-01-15 11:53:45 +0900 (7bd284b)
+++ lib/droonga/engine.rb    2015-01-15 12:32:35 +0900 (f2d00e0)
@@ -130,8 +130,16 @@ module Droonga
     def effective_message?(message)
       effective_timestamp = effective_message_timestamp
       return true if effective_timestamp.nil?
+      return true unless message["date"]
+
+      begin
+        message_timestamp = Time.parse(message["date"])
+      rescue ArgumentError => error
+        logger.error("failed to parse the \"date\" field of a message date",
+                     :message => message)
+        return false
+      end
 
-      message_timestamp = Time.parse(message["date"])
       logger.trace("checking effective_message_timestamp (#{effective_timestamp}) vs message_timestamp(message_timestamp)")
       return false if effective_timestamp >= message_timestamp
 
-------------- next part --------------
HTML����������������������������...
下载 



More information about the Groonga-commit mailing list
Back to archive index