Travis CI
notif****@travi*****
Sun Nov 17 23:33:17 JST 2013
Build Update for mroonga/mroonga
-------------------------------------
Build: #1012
Status: Errored
Duration: 16 minutes and 8 seconds
Commit: c4b16ed (master)
Author: Kouhei Sutou
Message: Move version check to hpp from cpp
We should check MySQL version and define logical flags in hpp and use
them in cpp. It improves maintenability.
Some flags are used in two or more locations. If they are used in two
or more locations, we need to write the same version check conditions
there. It reduces maintenability:
Not good:
#if MYSQL_VERSION_ID >= 50607
// code1
#endif
// ...
#if MYSQL_VERSION_ID >= 50607
// code2
#endif
Better:
#if MYSQL_VERSION_ID >= 50607
# define LOGICAL_FLAG
#endif
#ifdef LOGICAL_FLAG
// code1
#endif
// ...
#ifdef LOGICAL_FLAG
// code2
#endif
View the changeset: https://github.com/mroonga/mroonga/compare/2241a88711e0...c4b16ed9d95a
View the full build log and details: https://travis-ci.org/mroonga/mroonga/builds/14096742
--
You can configure recipients for build notifications in your .travis.yml file. See http://about.travis-ci.org/docs/user/build-configuration
-------------- next part --------------
An HTML attachment was scrubbed...
下载