For2.2.2-Refactoring: enum grid_bold_type conflicts with floor() from math.h

• 报告人: backwardseric
• 属主: hourier
• 类型: Support Request
• 状态: 关闭
• 组件: (无)
• 里程碑: 変愚蛮怒3.0.0alphaリリース (关闭)
• 优先: 3
• 严重性: 3
• 处理结果: Fixed
• 文件: 无

Details

The use of "floor" as one of the elements in the grid_bold_type enum defined in grid.h means that floor() from math.h can not be used in source code that includes angband.h or grid.h. That doesn't affect any of the current source code, but main-cocoa.m for the Mac OS X interface does happen to use floor(). There are workarounds, but would it be possible to change the definition of grid_bold_type enum to avoid the conflict? Prefixing all the current elements with "g_" for "grid" would avoid the conflict.

任务单历史 (3/6 Histories)

2020-01-22 02:11 Updated by: backwardseric

• New Ticket "For2.2.2-Refactoring: enum grid_bold_type conflicts with floor() from math.h" created

2020-01-22 21:35 Updated by: hourier

评论

It's my lack of understanding, thanks a lot for reporting this issue! I've already pushed the feature branch and you'll be able to merge from For2.2.2-Refactoring into your branch soon.

2020-01-23 01:00 Updated by: deskull

• 里程碑 Update from (无) to 変愚蛮怒3.0.0正式リリース (关闭)
• 属主 Update from (无) to deskull

2020-01-23 22:46 Updated by: hourier

评论

英語につき伝わりきらずすみません。昨日の時点で既に本件For2.2.2-Refactoring へマージされていますので、差分を確認し問題なければクローズ願います

2020-01-25 18:00 Updated by: deskull

• 属主 Update from deskull to hourier
• 状态 Update from 开启 to 关闭

评论

こちらこそ見逃していて申し訳ない。閉じます。

2021-01-02 09:53 Updated by: deskull

• 里程碑 Update from 変愚蛮怒3.0.0正式リリース (关闭) to 変愚蛮怒3.0.0alphaリリース (关闭)
• 处理结果 Update from 无 to Fixed