任务单 #40742

implicit declaration for gettimeofday in chuukei.c

开放日期: 2020-09-19 09:14 最后更新: 2021-01-24 21:42

报告人:
属主:
类型:
状态:
关闭
组件:
(无)
优先:
1 - Lowest
严重性:
2
处理结果:
Fixed
文件:
1

Details

When not on Windows, src/io/chuukei.c always makes use of gettimeofday() but only includes sys/time.h when CHUUKEI is set. The For2.2.2-Refactoring-chuukei-sys-time branch of hengbandforosx, https://osdn.net/projects/hengbandforosx/scm/git/hengbandosx/tree/For2.2.2-Refactoring-chuukei-sys-time/ , has a change so sys/time.h is included (at least if autoconf found it) by chuukei.c when not compiling for Windows. That avoids the implicit declaration of gettimeofday() which clang 12, with the default settings from ./configure, flags as an error. I've also attached the change as a patch to the For2.2.2-Refactoring branch from git format-patch.

任务单历史 (3/7 Histories)

2020-09-19 09:14 Updated by: backwardseric
  • New Ticket "implicit declaration for gettimeofday in chuukei.c" created
2020-09-21 21:04 Updated by: hourier
  • 属主 Update from (无) to hourier
评论

We discussed this issue in Hengband dev team.

As a result, we'll remove this feature from the software.

The reason is that the function to relay video of the play is not currently used, and it is unlikely that it'll be used in the future.

I'll inform you when the removing task is finished.

Please wait for a while.

2020-09-22 18:49 Updated by: hourier
  • 处理结果 Update from to Fixed
  • 属主 Update from hourier to deskull
评论

I removed the pre processor and renamed chuukei.c/h to record-play-movie.c/h.

Additionally, I refactored game-play.c also because it's complicated.

deskull 氏

後ほどマージ願います

2020-10-08 00:51 Updated by: backwardseric
评论

The refactoring of chuukei.c/h to record-play-movie.c/h has compiler errors when compiled with clang 12 on OS X. The last three commits on the For2.2.2-Refactoring-record-play-movie branch of hengbandforosx, https://osdn.net/projects/hengbandforosx/scm/git/hengbandosx/commits?branch=For2.2.2-Refactoring-record-play-movie-fixes , are what I did to resolve those errors.

2020-10-13 00:06 Updated by: deskull
  • 状态 Update from 开启 to 关闭
评论

I merged your last commit of For2.2.2-Refactoring-record-play-movie-fixes. Thanks for your fix.

2021-01-24 21:42 Updated by: deskull
评论

3.0.0Alpha以前に修正していたが、便宜的に正式版で修正したものとする。

Attachment File List

编辑

Please login to add comment to this ticket » 登录名