WORLD_SCORE not set: save/save.c missing prototypes

• 报告人: backwardseric
• 属主: habu
• 类型: Patches
• 状态: 关闭
• 组件: (无)
• 里程碑: 変愚蛮怒3.0.0Alpha5リリース (关闭)
• 优先: 1 - Lowest
• 严重性: 1 - Lowest
• 处理结果: Duplicate
• 文件: 无

Details

When WORLD_SCORE is not set, io/report.h does not include io/files-util.h. Since save/save.c uses savefile, debug_savefile, and counts_write() from io/files-util.h, compiling save/save.c with the clang compiler (version 12) and WORLD_SCORE not set leads to compiler errors for missing prototypes for the symbols declared in io/report.h.

This commit, https://osdn.net/projects/hengbandforosx/scm/git/hengbandosx/commits/e159659d0216e44aed597dc25623bef8f7d797f4 , (clang-save-missing-prototypes branch on the hengbandforosx project; branch is based off Hengband's develop branch) always includes io/files-util.h in save/save.c so those prototypes are available regardless of the setting for WORLD_SCORE.

任务单历史 (3/3 Histories)

2021-02-06 06:52 Updated by: backwardseric

• New Ticket "WORLD_SCORE not set: save/save.c missing prototypes" created

2021-02-06 15:42 Updated by: habu

• 状态 Update from 开启 to 关闭
• 处理结果 Update from 无 to Duplicate

评论

I had noticed this problem some time ago and had created a ticket #41444 for this issue.

Your series of commits (tickets #41480 #41481 #41482) will be taken in and this issue will be dealt with in ticket #41444.

Thank you.

2021-02-06 21:26 Updated by: deskull

• 属主 Update from (无) to habu
• 里程碑 Update from (无) to 変愚蛮怒3.0.0Alpha5リリース (关闭)