[macemacsjp-english 711] Re: Transparency patch (again)

Back to archive index

Peter Dyballa Peter_Dybal****@Web*****
Thu Oct 5 04:59:46 JST 2006


Am 04.10.2006 um 17:57 schrieb Seiji Zenitani:

> Hi,
>
> I received the transparency patch for Emacs 23.
> http://macemacsjp.sourceforge.jp/package/test/
>

This patch looks a bit incomplete, for example for src/frame.c:

	+Lisp_Object Qactive_alpha, Qinactive_alpha;

These variables can interfere on some platforms. I've integrated this  
line as

	+#if defined (HAVE_CARBON) || defined (WINDOWSNT) || defined  
(HAVE_X_WINDOWS)
	+Lisp_Object Qactive_alpha;
	+Lisp_Object Qinactive_alpha;
	+#endif

as the original patch contains them. And the same for

	+  {"active-alpha",		&Qactive_alpha},
	+  {"inactive-alpha",		&Qinactive_alpha},

vs.

	+#if defined (HAVE_CARBON) || defined (WINDOWSNT) || defined  
(HAVE_X_WINDOWS)
	+  {"active-alpha",		&Qactive_alpha},
	+  {"inactive-alpha",		&Qinactive_alpha},
	+#endif

and some more. Can it be this is an attempt to remove/clean some  
useless lines? Most original patch lines were not so cleanly embedded  
like these examples ...


For src/xfns.c this line was forgotten?

	+extern void x_set_frame_alpha P_ ((struct frame *, int));


For src/w32fns.c this line is added:

	+extern SetLayeredWindowAttributes_Proc  
set_layered_window_attributes_fn;


--
Greetings

   Pete

Got Mole problems?
Call Avogadro 6.02 x 10^23





More information about the macemacsjp-english mailing list
Back to archive index