Peter Zijlstra
peter****@infra*****
2017年 8月 29日 (火) 18:04:30 JST
ForkOn Tue, Aug 29, 2017 at 08:30:15AM +0200, Greg KH wrote:
> On Thu, Jul 06, 2017 at 09:34:18AM -0700, Babu Moger wrote:
> > Resending the series per Greg KH's request.
> >
> > Found this problem while enabling queued rwlock on SPARC.
> > The parameter CONFIG_CPU_BIG_ENDIAN is used to clear the
> > specific byte in qrwlock structure. Without this parameter,
> > we clear the wrong byte.
> > Here is the code in include/asm-generic/qrwlock.h
> >
> > static inline u8 *__qrwlock_write_byte(struct qrwlock *lock)
> > {
> > return (u8 *)lock + 3 * IS_BUILTIN(CONFIG_CPU_BIG_ENDIAN);
> > }
> >
> > Also found few more references of this parameter in
> > drivers/of/base.c
> > drivers/of/fdt.c
> > drivers/tty/serial/earlycon.c
> > drivers/tty/serial/serial_core.c
> >
> > Here is our previous discussion.
> > https://lkml.org/lkml/2017/5/24/620
> >
> > Based on the discussion, it was decided to add CONFIG_CPU_BIG_ENDIAN
> > for all the fixed big endian architecture(frv, h8300, m68k, openrisc,
> > parisc and sparc). And warn if there are inconsistencies in this definition.
>
> Did this series ever get picked up by anyone? I don't know whose tree
> it should go through if not, anyone have any ideas? I guess I could,
> but arch-specific stuff is odd...
Seems like something that akpm would pick up, but it appears people
didn't actually Cc him.