任务单 #43059

ruleset.c comments about global_unit_options

开放日期: 2021-10-18 03:20 最后更新: 2022-08-01 18:34

报告人:
属主:
类型:
状态:
关闭
组件:
里程碑:
优先:
5 - Medium
严重性:
5 - Medium
处理结果:
Fixed
文件:
1

Details

There is no global_unit_options section any more in master. Grep reveals that there still is some comments in ruleset.c referring to it. Maybe need changing in older branches too, to reflect the fact that the section will disappear in 3.2.

任务单历史 (3/10 Histories)

2021-10-18 03:20 Updated by: cazfi
  • New Ticket "ruleset.c comments about global_unit_options" created
2022-01-27 12:55 Updated by: cazfi
  • 里程碑 Update from (无) to 3.0.1 (关闭)
  • 组件 Update from (无) to Server
2022-03-13 02:09 Updated by: dark-ether
评论

i could just remove the comments and submit a patch, but what are the plans regarding those options? they are things that are unit related,so they make sense to be in a section specifically about units, should nothing be done about them and just remove the comments? or should i move them to units.ruleset control section?

2022-03-13 04:37 Updated by: cazfi
评论

They have something to do with units, yes, but IMHO they are still more about civstyle than about units (belong to game.ruleset more than to units.ruleset). At this point I would just remove the comments.

2022-04-09 04:14 Updated by: cazfi
评论

Reply To dark-ether

i could just remove the comments and submit a patch

Will you?

2022-04-13 20:16 Updated by: cazfi
2022-06-11 21:50 Updated by: cazfi
2022-07-25 04:14 Updated by: cazfi
  • 属主 Update from (无) to cazfi
  • 处理结果 Update from to Accepted
2022-08-01 18:34 Updated by: cazfi
  • 状态 Update from 开启 to 关闭
  • 处理结果 Update from Accepted to Fixed

编辑

Please login to add comment to this ticket » 登录名