提交: b02cd3e978e9273074f7cbe2ca1d5b372225a56d - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• 修订版: b02cd3e978e9273074f7cbe2ca1d5b372225a56d (tree)
• 时间: 2017-04-23 20:03:35
• 作者: Alan Modra <amodra@gmai...>
• Commiter: Alan Modra

Log Message

PR 21415, objdump fails to check bfd_get_section_contents status

PR 21415
* objdump.c (disassemble_section): Check bfd_get_section_contents
status.

更改概述

• modified: binutils/ChangeLog
• modified: binutils/objdump.c

差异

--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,5 +1,11 @@
 2017-04-23  Alan Modra  <[e-mail]>
 
+	PR 21415
+	* objdump.c (disassemble_section): Check bfd_get_section_contents
+	status.
+
[phone]  Alan Modra  <[e-mail]>
+
 	PR 21408
 	* dwarf.c (display_debug_lines_decoded): Don't segfault on NULL
 	file_table.

--- a/binutils/objdump.c
+++ b/binutils/objdump.c
@@ -2174,7 +2174,12 @@ disassemble_section (bfd *abfd, asection *section, void *inf)
 
   data = (bfd_byte *) xmalloc (datasize);
 
-  bfd_get_section_contents (abfd, section, data, 0, datasize);
+  if (!bfd_get_section_contents (abfd, section, data, 0, datasize))
+    {
+      non_fatal (_("Reading section %s failed because: %s"),
+		 section->name, bfd_errmsg (bfd_get_error ()));
+      return;
+    }
 
   paux->sec = section;
   pinfo->buffer = data;