akmdm akmdm akmdm I want to make some changes to the patches, I'll resubmit them in a few hours.
EDIT: I resubmitted private_chat.patch. Now clients can send private messages to the server and only private messages to/from the server are logged in the server's chat log. Private chat messages between two players won't be logged.
chat_sound.patch is dependent on private_chat.patch.
EDIT 2: I submitted another patch that fixes a small issue with the private messages.
akmdm)
akmdm akmdm akmdm Thanks for the patch! Sounds like a very useful feature.
I started to look at the code in detail and noticed that it would simplify things a lot if I could leave comments directly in the code, like we used to in merge requests on bitbucket. Do you know if OSDN supports this? If not, it would be great if we find a different platform where this is possible.
akmdm Reply To torr_samaho
Thanks for the patch! Sounds like a very useful feature. I started to look at the code in detail and noticed that it would simplify things a lot if I could leave comments directly in the code, like we used to in merge requests on bitbucket. Do you know if OSDN supports this? If not, it would be great if we find a different platform where this is possible.
I don't think OSDN has this feature, but I could be wrong.
akmdm)
I think so too. Are you familiar with the hg-git bridge? https://hg-git.github.io/
You could just create a git mirror of your hg repository and we use github for the code commenting.
Reply To torr_samaho
I think so too. Are you familiar with the hg-git bridge? https://hg-git.github.io/ You could just create a git mirror of your hg repository and we use github for the code commenting.
I'll take look at this plugin you sent me, I can create a mirror on my GitHub account and we can go forward from there. This would be extremely useful for the larger commits/changes that require more review. Thanks for the suggestion.
akmdm I created a mirror of "zandronum-stable" on my GitHub account, you can access the commit for the private messaging here: https://github.com/AKMDM/Zandronum/commit/6b2c688e07102a2ca16cc40bdb040b9bcbf8855c
akmdm)
akmdm akmdm Thanks for the GitHub mirror and the updated patch! Is the updated patch already on GitHub? At least the time stamp of the new patch in the ticket is two days newer then the GitHub commit you linked further up?
akmdm Reply To torr_samaho
Thanks for the GitHub mirror and the updated patch! Is the updated patch already on GitHub? At least the time stamp of the new patch in the ticket is two days newer then the GitHub commit you linked further up?
It's the same one only that I uploaded it here late.
akmdm I added some new patches to complement further changes or fixes to the chat and console.
EDIT: Here's a link to the commit which adds the new EVENT type on my GitHub repo: https://github.com/AKMDM/Zandronum/commit/ce07f2bdab0c2777d7b3977915c2b1da68a0f8aa
akmdm)
I added 10234.patch, 10235.patch and 10238.patch.
The other two new patches are meant to refine the private chat patch, right? I'll have to look at their union then.
akmdm akmdm akmdm Reply To torr_samaho
The other two new patches are meant to refine the private chat patch, right? I'll have to look at their union then.
That's correct. 10237.patch particularly fixes a compiler warning caused by the introduction of private_chat_mode.patch.
EDIT: Sorry to ask this, but could 10236.patch be ignored for the time being? After some thought, I'm not sure how useful the new EVENT type and ACS function would really be to modders, and I think the way I implemented it isn't too great either. I would much rather replace this patch with something better.
akmdm)
EDIT: Sorry to ask this, but could 10236.patch be ignored for the time being? After some thought, I'm not sure how useful the new EVENT type and ACS function would really be to modders, and I think the way I implemented it isn't too great either. I would much rather replace this patch with something better.
No problem.
To further simplify the review, can you convert this into a pull request for https://github.com/TorrSamaho/zandronum ? Then, we can do the review and handle all possibly adjustments within one GitHub pull request. That should be much simpler then continuously posting new patch files which are refining or replacing existing patch files.
akmdm Reply To torr_samaho
To further simplify the review, can you convert this into a pull request for https://github.com/TorrSamaho/zandronum ? Then, we can do the review and handle all possibly adjustments within one GitHub pull request. That should be much simpler then continuously posting new patch files which are refining or replacing existing patch files.
Sure, I will do that as soon as possible.
EDIT: Here's the pull request: https://github.com/TorrSamaho/zandronum/pull/1
akmdm)
Has been taken care by now.
Fork
This addresses following Zandronum ticket: https://zandronum.com/tracker/view.php?id=354
The following patches adds a new chat mode enabling players to send private messages to each other without other players seeing them, but the server can still see the messages in the chat log. This is done through two console commands: "sayto" (accepts player names) and "sayto_idx" (accepts player numbers), much like in ZDaemon. Let's assume Player #1 sends a private message to Player #2:
1. Player #1 will see: "<To Player #2>: message". 2. Player #2 will see: "<From Player #1>: message". 3. If the server sent a private message to either player, they will see: "<From Server>: message". 4. "/me" commands are also handled accordingly like in other chat modes.
For private messaging to work, there must be another player to send a message to, a player cannot send a private message to themselves. Also, if LMS spectator settings are in effect, a message will only be printed on the screen indicating if this particular player will not see or be able to chat back with us. Private messages are printed on a new message level that's one above team chat messages, and also use a custom sound (the Doom 1 chat sound by default) and text color (cyan by default), both of which can be changed by the client through the console or menus.
I made sure to comment wherever necessary, especially in spots that require (G)ZDoom delta, and I tried testing this both offline and online to make sure it works as intended.